Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pagination speakers module #238

Merged

Conversation

auliafaizahr
Copy link
Collaborator

@auliafaizahr auliafaizahr commented Aug 6, 2024

Title: Add Pagination to Speaker List and Adjust Layout

Description
Feature Request: As an admin user, I want to manage Speakers for our Events.

Related Problem:
The list of speakers in speaker module is expected to grow significantly, making it difficult to maintain and navigate.

Solution:
This pull request adds pagination to the speaker list to improve usability. The solution utilizes the Pagy gem for pagination and Bootstrap for styling.

Changes:

image

  • Added pagination using pagy gem to the speaker list with 15 elements per page.
  • Moved the "Create Speaker" button to share the same row with the title.
  • Adjusted the layout to position the pagination controls on top of the view.

Related Issues: #184

Waiting for review the changes and provide feedback from reviewer, thankyou.

Copy link

@kajatiger kajatiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice!

Copy link
Collaborator

@luciagirasoles luciagirasoles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations for the work done here 🎉! It looks so good! we still need to improve in this PR is how we display the composition of this component in this page. Let's try to keep the same structure as it is in the Event List for Desktop and Mobile screens. (Images sent on Slack)

Gemfile.lock Outdated Show resolved Hide resolved
Copy link
Collaborator

@luciagirasoles luciagirasoles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the upgrades and for supporting the community.

@luciagirasoles luciagirasoles merged commit b36ef10 into wnbrb:main Aug 18, 2024
2 checks passed
@luciagirasoles
Copy link
Collaborator

closes #238

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants